From: Dave Stevenson Date: Tue, 14 Mar 2017 14:23:06 +0000 (+0000) Subject: bcm2835-gpio-exp: Copy/paste error adding base twice X-Git-Tag: archive/raspbian/4.9.80-2+rpi1~5^2~265 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=0ffe06c770555e9b81cf64733de8fe2667000c55;p=linux-4.9.git bcm2835-gpio-exp: Copy/paste error adding base twice brcmexp_gpio_set was adding gpio->gc.base to the offset twice, so passing an invalid number to the mailbox service. The firmware treated it modulo-8 anyway, but was logging an assert every time. Signed-off-by: Dave Stevenson --- diff --git a/drivers/gpio/gpio-bcm-exp.c b/drivers/gpio/gpio-bcm-exp.c index 681a91492d4c..d68adafaee4a 100644 --- a/drivers/gpio/gpio-bcm-exp.c +++ b/drivers/gpio/gpio-bcm-exp.c @@ -165,8 +165,6 @@ static void brcmexp_gpio_set(struct gpio_chip *gc, unsigned int off, int val) gpio = container_of(gc, struct brcmexp_gpio, gc); - off += gpio->gc.base; - set.gpio = off + gpio->gc.base; /* GPIO to update */ set.state = val; /* Output state */